user instructor image name save issue fixed

app/Http/Controllers/Backend/Instructors/InstructorController.php

@@ -5,7 +5,6 @@
 use App\Http\Controllers\Controller;
 use App\Models\Instructor;
 use App\Models\User;
-use Illuminate\Http\Request;
 use App\Http\Requests\Backend\Instructors\AddNewRequest;
 use App\Http\Requests\Backend\Instructors\UpdateRequest;
 use App\Models\Role;
@@ -56,11 +55,11 @@ public function store(AddNewRequest $request)
             $instructor->language = 'en';
             $instructor->access_block = $request->access_block;
             if ($request->hasFile('image')) {
-                $roleName = Role::find($request->role_id)?->name;
-                $imageName = $roleName.'-'.$request->name_en.'.'. $request->image->extension();
+                $imageName = (Role::find($request->roleId)->name) . '_' .  $request->fullName_en . '_' . rand(999, 111) .  '.' . $request->image->extension();
                 $request->image->move(public_path('uploads/users'), $imageName);
                 $instructor->image = $imageName;
             }
+
             if ($instructor->save()) {
                 $user = new User;
                 $user->instructor_id = $instructor->id;
@@ -131,13 +130,12 @@ public function update(UpdateRequest $request, $id)
             $instructor->password = Hash::make($request->password);
             $instructor->language = 'en';
             $instructor->access_block = $request->access_block;
-
             if ($request->hasFile('image')) {
-                $roleName = Role::find($request->role_id)?->name;
-                $imageName = $roleName . '-' . $request->name_en . '.' . $request->image->extension();
+                $imageName = (Role::find($request->roleId)->name) . '_' .  $request->fullName_en . '_' . rand(999, 111) .  '.' . $request->image->extension();
                 $request->image->move(public_path('uploads/users'), $imageName);
                 $instructor->image = $imageName;
             }
+
             if ($instructor->save()) {
                 $user = User::where('instructor_id', $instructor->id)->first();
                 $user->instructor_id = $instructor->id;